Skip to content

Build: ENABLE_SEVENZIP and ENABLE_ZIP still require ENABLE_XML #4947

@EnghouseTomy

Description

@EnghouseTomy

Describe the bug
#2929 removed dependency of Zip and SevenZip on Util, XML, JSON in their respective CMakeLists.txt.
However, top level CMakeLists.txt still requires ENABLE_XML if SevenZip is to be compiled.
Same goes for Zip support.

if(EXISTS ${PROJECT_SOURCE_DIR}/SevenZip AND ENABLE_SEVENZIP AND ENABLE_XML)
	add_subdirectory(SevenZip)
	list(APPEND Poco_COMPONENTS "SevenZip")
endif()

if(EXISTS ${PROJECT_SOURCE_DIR}/Zip AND ENABLE_ZIP AND ENABLE_XML)
	add_subdirectory(Zip)
	list(APPEND Poco_COMPONENTS "Zip")
endif()

To Reproduce
Try using only ENABLE_SEVENZIP=ON ENABLE_XML=OFF and SevenZip will not be compiled.

Expected behavior
Using only ENABLE_SEVENZIP=ON ENABLE_XML=OFF, SevenZip should be compiled.

Please add relevant environment information:

  • OS Windows (not relevent I believe)
  • POCO latest github source

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions