Skip to content

fix: return 2FA users to account - #152

Merged
korone00 merged 1 commit into
mainfrom
fix/2fa-account-redirect
Aug 7, 2026
Merged

fix: return 2FA users to account#152
korone00 merged 1 commit into
mainfrom
fix/2fa-account-redirect

Conversation

@korone00

@korone00 korone00 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return regular users to the shared account page after two-factor enrollment
  • keep the account route behind the mandatory enrollment gate
  • verify TOTP, backup-code, enrollment, and setup re-entry flows against real account content

Root cause

The admin route split made /admin and /admin/account admin-only, but the two-factor setup redirects and disposable-user tests still targeted those paths. URL-only assertions could therefore accept a forbidden page as success.

Validation

  • CLI lint and generated-file tests
  • generated app Svelte check
  • focused account and two-factor Playwright tests
  • faithful isolated smoke: 34 passed, 3 environment-dependent tests skipped

@korone00
korone00 merged commit 9892142 into main Aug 7, 2026
3 checks passed
@korone00
korone00 deleted the fix/2fa-account-redirect branch August 7, 2026 08:07
@github-actions github-actions Bot mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant