Skip to content

Comments

adds unit testing tools#154

Merged
warrenv merged 1 commit intomasterfrom
add_unit_testing_tools
Jun 15, 2018
Merged

adds unit testing tools#154
warrenv merged 1 commit intomasterfrom
add_unit_testing_tools

Conversation

@warrenv
Copy link
Contributor

@warrenv warrenv commented Jun 14, 2018

Description of Changes

  • Adds ts-node, riteway, sinon as unit and integration testing tools

Run:

  $ npm install
  $ npm run test:unit

You should see 2 passing tests.

PR Review Checklist

  • Have you tested the changes?
  • Is QE review required? If so, has this been reviewed by QE? (For all new features, review by QE is required. Minor changes which already have passing functional tests may not need a new QE review -- when in doubt, loop in a QE reviewer).
  • Are there code changes that require new unit tests? If so, are those tests included? (A separate PR for tests is not appropriate).
  • Are documentation updates required? If so, does this PR include it? (Separate documentation PR is generally not appropriate).
  • Are the added/edited files named appropriately and located correctly in the project directory structure?

- Adds and configures ts-node, riteway and sinon.
- Adds an example unit test file.
- Adds a pretest npm script
- Adds a test:unit npm script
@warrenv warrenv force-pushed the add_unit_testing_tools branch from 6a14468 to 2e61fd1 Compare June 15, 2018 15:21
Copy link
Contributor

@jwicks31 jwicks31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Checklist

  • Have you tested the changes?
  • Is QE review required? If so, has this been reviewed by QE? (For all new features, review by QE is required. Minor changes which already have passing functional tests may not need a new QE review -- when in doubt, loop in a QE reviewer).
  • Are there code changes that require new unit tests? If so, are those tests included? (A separate PR for tests is not appropriate).
  • Are documentation updates required? If so, does this PR include it? (Separate documentation PR is generally not appropriate).
  • Are the added/edited files named appropriately and located correctly in the project directory structure?

@warrenv warrenv merged commit b79d929 into master Jun 15, 2018
@warrenv warrenv deleted the add_unit_testing_tools branch June 15, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants