Conversation
d85021d to
6a14468
Compare
- Adds and configures ts-node, riteway and sinon. - Adds an example unit test file. - Adds a pretest npm script - Adds a test:unit npm script
6a14468 to
2e61fd1
Compare
jwicks31
approved these changes
Jun 15, 2018
Contributor
jwicks31
left a comment
There was a problem hiding this comment.
PR Review Checklist
- Have you tested the changes?
- Is QE review required? If so, has this been reviewed by QE? (For all new features, review by QE is required. Minor changes which already have passing functional tests may not need a new QE review -- when in doubt, loop in a QE reviewer).
- Are there code changes that require new unit tests? If so, are those tests included? (A separate PR for tests is not appropriate).
- Are documentation updates required? If so, does this PR include it? (Separate documentation PR is generally not appropriate).
- Are the added/edited files named appropriately and located correctly in the project directory structure?
kennylavender
approved these changes
Jun 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Run:
You should see 2 passing tests.
PR Review Checklist