Skip to content

Conversation

@cwognum
Copy link
Collaborator

@cwognum cwognum commented Feb 2, 2025

Changelogs

  • Remove the emoji from the log

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

Fixes #263

Expect this to fail on Windows
@cwognum cwognum self-assigned this Feb 2, 2025
@cwognum
Copy link
Collaborator Author

cwognum commented Feb 2, 2025

Hmm... I was expecting the new test case to fail for Windows. Let's see if I can reproduce the error in our CICD.

@cwognum cwognum added the fix Annotates any PR that fixes bugs label Feb 2, 2025
Copy link

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes my issue #263. I tested on the same machine with

pip install -U git+https://github.com/polaris-hub/polaris.git@2737b66c72d7daf67ee7e2062d2c0316c611efe7

and now get

$ polaris login
[2025-02-02 17:32:29] INFO     You are successfully logged in to  client.py:252
                               the Polaris Hub.

I'm not sure why the tests here didn't reproduce the problem. I'm on Windows 10, which could be a difference. Other system information from conda info that could point to environment differences

user-agent : conda/23.1.0 requests/2.31.0 CPython/3.9.18 Windows/10 Windows/10.0.19045 solver/libmamba conda-libmamba-solver/22.8.1 libmambapy/1.3.1 aau/0.4.3 c/MJFdvaQxP8tx_bXR_Hb8eg s/fa04h50TeXGA8K05bh0tNQ e/UibNJO7p5_nb6vlS3wqlrA

but it doesn't matter because the problem is resolved.

Copy link
Contributor

@jstlaurent jstlaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cwognum cwognum merged commit 787cdb3 into main Feb 3, 2025
19 checks passed
@cwognum cwognum deleted the fix/emoji-use-on-windows branch February 3, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Annotates any PR that fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

polaris login gives UnicodeEncodeError

4 participants