Skip to content

Auto Generated Documentation#6

Merged
dlackty merged 4 commits intopolydice:developfrom
bcylin:feature/auto-generated-docs
Oct 7, 2016
Merged

Auto Generated Documentation#6
dlackty merged 4 commits intopolydice:developfrom
bcylin:feature/auto-generated-docs

Conversation

@bcylin
Copy link
Copy Markdown
Collaborator

@bcylin bcylin commented Oct 2, 2016

Using @polydicebot's DANGER_GITHUB_API_TOKEN to push updates to gh-pages, it'll need some help on the following setups for testing:

@bcylin bcylin force-pushed the feature/auto-generated-docs branch from 6fff33d to 7d7ddb8 Compare October 5, 2016 14:45
@bcylin
Copy link
Copy Markdown
Collaborator Author

bcylin commented Oct 5, 2016

It seems that Travis CI doesn't export env variables in a PR build from a forked repo.

PR #6 is missing the following setup:

Setting environment variables from repository settings
$ export DANGER_GITHUB_API_TOKEN=[secure]

but PR #4 has.

If the failure message is sent to the Slack channel, maybe DANGER_GITHUB_API_TOKEN can be like the Slack token, encrypted in the .travis.yml using the travis gem. Any ideas on this issue?

@dlackty
Copy link
Copy Markdown
Member

dlackty commented Oct 6, 2016

It seems that Travis CI doesn't export env variables in a PR build from a forked repo.

I believed that's because they don't want to expose sensitive data to 3rd party contributors. Otherwise a malicious attacker can create a pull request to just echo those sensitive data.

Maybe we can change documentation generation script a bit to only generate docs on master branch which will usually happen in original repo?

@bcylin
Copy link
Copy Markdown
Collaborator Author

bcylin commented Oct 6, 2016

Oh that makes sense. Just updated. Now it skips danger and gh-pages updates when the token is not available.

@dlackty dlackty merged commit 24d1db5 into polydice:develop Oct 7, 2016
@dlackty
Copy link
Copy Markdown
Member

dlackty commented Oct 7, 2016

Just merged in. Thanks for contribution!

@bcylin bcylin deleted the feature/auto-generated-docs branch October 7, 2016 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants