Merge latest whatsmeow changes - #40
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb386f1528
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get user info for %s to fill LID cache: %w", jid, err) | ||
| } | ||
| lid = info[jid].LID |
There was a problem hiding this comment.
Normalize the JID before indexing user info
When the caller supplies an AD phone-number JID and its LID is not cached, GetUserInfo strips the device via ToNonAD() and keys its result map by the normalized JID, so indexing with the original jid misses the returned entry and incorrectly reports that the server supplied no LID. Normalize the JID before both the lookup and subsequent blocklist request so user-level blocking works for device JIDs.
Useful? React with 👍 / 👎.
|
This upstream-head PR cannot accept Polymorfa conflict-resolution commits ( |
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.