ct-runner: --translator/DELTIC_TRANSLATOR for consumers outside a checkout - #23
Merged
Conversation
…ckout The CLI's translator lookup was repo-relative (target/...), which cannot work when the runner is imported by URL at a release tag — the consumer migration path (#14): polymorph-test's deltic lane pins a pre-<hash> tag and takes the wasm from that release's deltic-translator-shim.wasm asset (#16 interim scheme). Resolution order: --translator, DELTIC_TRANSLATOR, checkout-local build; a non-file: import.meta.url now fails loud with the release-asset hint instead of a readFile error. CLI-level subprocess tests cover all three paths (the fixture suite's deliberate failure keeps exit-1 discipline). Verified remote consumption end to end: runtime+ct-runner graph resolves over raw.githubusercontent at pre-40152e2 with the release-asset translator; fixture counts and L4 envelope exact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 of the polymorph-test migration (#14): the CLI's translator lookup was repo-relative, which cannot work when the runner is imported by URL at a release tag. Consumers now name the wasm explicitly (
--translator/DELTIC_TRANSLATOR), taking it from the release'sdeltic-translator-shim.wasmasset (#16 interim scheme); inside a checkout the local-build default stands. A non-file:import.meta.urlfails loud with the release-asset hint.Gates:
ct-runnercheck + test (new CLI subprocess tests; 10/10, +seeds 1/4242). Remote-consumption probe: full runtime+ct-runner graph over raw.githubusercontent atpre-40152e2, release-asset translator, fixture counts + L4 envelope exact.Unblocks the side-by-side
verify-delticlane PR in polymorph-test (pins the next prerelease tag).