stream-dom-dioxus: spell an asset handle as asset:<hex> in attribute values - #19
Merged
Conversation
…values Dioxus attribute values are strings, so the writer had no way to emit the protocol's asset arm; every href/src reached the receiver as text, which a policy requiring asset-valued URLs rejects. An attribute value of the form asset:<hex> now decodes to the asset arm on both the static-template and dynamic set-attribute paths. Anything else is text, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dioxus attribute values are strings, so
stream-dom-dioxusreduced every value to the protocol'stextarm and a Dioxus producer could not name an asset — a host whose policy requires asset-valuedhref/src(polyvisor) could not be handed a stylesheet by a Dioxus app.A value of the form
asset:<hex>(non-empty, even-length hex) now decodes to theassetarm, on both the static-template and dynamicset_attributepaths. Anything else is text, exactly as before. Receiver and host untouched; they already handle the arm.Tests in
writer_stream.rscover both paths and the near-miss strings;docs/design.mdrecords the convention.Automerge armed.