Skip to content

js: caller-owned report keys in the page runner; only passthrough #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lann merged 1 commit into from
Aug 7, 2026
+13 −9
Merged

js: caller-owned report keys in the page runner; only passthrough #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js/viewer/browser-worker.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ self.onmessage = async ({ data }) => {
contextUrl,
env = [],
missing = [],
only,
shard,
caseTimeoutMs,
} = data;
Expand Down Expand Up @@ -67,6 +68,7 @@ self.onmessage = async ({ data }) => {
Context,
tagsOf,
missing,
only,
shard,
caseTimeoutMs,
emit: (event, index) => self.postMessage({ kind: "event", index, event }),
Expand Down
20 changes: 11 additions & 9 deletions js/viewer/page-runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,23 @@ function runShard(workerUrl, config, shard, onRow) {
}

/**
* Run every configured suite and report, keyed by `target` — the one
* identity unique per run (several targets may run one suite, e.g. a
* plain and a delegated composition of the same corpus). `suites`
* entries carry the browser-worker run message minus `shard`
* Run every configured suite and report, keyed by each entry's `key`
* (default: its `target`). Neither `suite` nor `target` is unique on
* its own across consumers — one suite may run as several targets (a
* plain and a delegated composition), and one target may run several
* suites (a main and a signing corpus) — so the caller owns the key.
* `suites` entries carry the browser-worker run message minus `shard`
* (moduleUrl, coreUrls, importsUrl, contextUrl?, env?, missing?,
* caseTimeoutMs?) plus `suite` (the results identity in the envelope)
* and `target`. `jobs` defaults to the capped hardware parallelism;
* pass 1 for sequential corpora.
* only?, caseTimeoutMs?) plus `suite` (the results identity in the
* envelope) and `target`. `jobs` defaults to the capped hardware
* parallelism; pass 1 for sequential corpora.
*/
export async function runSuitesInPage({ workerUrl, suites, jobs }) {
const pool = jobs ?? workerCount(navigator.hardwareConcurrency ?? 4);
let rows = 0;
try {
const out = {};
for (const { suite, target, ...config } of suites) {
for (const { suite, target, key = target, ...config } of suites) {
beat(`suite ${suite}: ${pool} workers`);
const shards = await Promise.all(
Array.from({ length: pool }, (_, index) =>
Expand All @@ -71,7 +73,7 @@ export async function runSuitesInPage({ workerUrl, suites, jobs }) {
);
const events = shards.flatMap((s) => s.events);
events.sort((a, b) => a.index - b.index);
out[target] = {
out[key] = {
lines: [
JSON.stringify(envelope(target, suite)),
...events.map((e) => JSON.stringify(e.event)),
Expand Down
Loading