Skip to content

Rust/WIT polish: undocumented policy getters, unused re-exports, literal drift #290

Description

@lann

Low-severity items from adversarial review:

  • pub fn policy() is documented in rust/core/src/cipher.rs:193 but undocumented at its siblings rust/core/src/agreement.rs:563 and rust/core/src/kdf.rs:46/77/304, in modules where every neighboring pub getter has a doc.
  • Unused public re-exports from rust/core: UseFamily (lib.rs:86) and not_permitted (lib.rs:92) have no external consumers (RsaScheme is signature-forced via SigPublic). publish = false, so cost is only seam clarity.
  • conformance/guest/src/translate.rs:27 says "a deterministic 1-in-20 sample" while the governing constant REJECTION_STRADDLE_SAMPLE = 20 (line 20) is documented as 1-in-N; the prose lies if the constant changes.
  • wit/rsa.wit:143 is the only doc line in the package exceeding 80 columns (99 chars); reads like an un-rewrapped edit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions