conformance-ct: ct-driver grows --only (single-case runs on the wasmtime target) - #317
Merged
Conversation
…ime target) The generic ct-runner and the jco runner both had a --only substring filter; the host-embed wasmtime driver did not, so bisecting a failure on the primary target meant running all 18k cases. Plumb the existing run_suite_opts only-filter through, with upstream semantics: filtered cases are omitted from output, so filtered runs do not aggregate cleanly - by design, it is a dev-loop tool. Fixes #308.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308. Plumbs component-test's existing
run_suite_optsonly-filter through the host-embed driver, matching ct-runner's and the jco runner's--only(substring; filtered cases omitted from output, so filtered runs deliberately don't aggregate). Verified:--only ed25519/wycheproof/tc1runs the 162 matching cases; a trailing-slash substring narrows to one case.