Drop the vendored componentize-js patch: the rooting fix landed upstream - #58
Merged
Conversation
dicej/componentize-js#5 fixes the rooting assertion failure on async-import rejection (the bug the vendored componentize-js-rooting-fix.patch worked around), so the pin in componentize-sdk/componentize-js.rev moves to that revision and the patch — and every install/build step that applied it — is gone. The library's callImport settlement normalization stays: the raw-result-wrapper shape for imports that complete without suspending is unchanged upstream. The new runner component for the updated input lock is published on the wpt-components release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dicej/componentize-js#5 fixes the rooting assertion failure on async-import rejection — the bug
componentize-js-rooting-fix.patchworked around — so:componentize-sdk/componentize-js.revmoves to upstreameed6d46(the fix's merge commit),err.The library's
callImportsettlement normalization stays: the other quirk (imports that complete without suspending resolve with the raw canonical{tag, val}result wrapper) is unchanged upstream, and the normalization tolerates both shapes either way.Verified with the unpatched upstream CLI at the new pin: the demo passes (9 checks) and the WPT gate passes (149/149 in-subset). The runner component for the updated input lock (
e9a8669ca5184f6d) is already published on thewpt-componentsrelease, so CI'swpt-componentjob stays a download.