Skip to content
This repository was archived by the owner on Jan 21, 2024. It is now read-only.

sponsorblock: use serviceId instead of string comparison to determine…#307

Merged
polymorphicshade merged 1 commit into
polymorphicshade:sponsorblockfrom
bravepipeproject:use-serviceId-to-determine-youtube-service
Apr 8, 2023
Merged

sponsorblock: use serviceId instead of string comparison to determine…#307
polymorphicshade merged 1 commit into
polymorphicshade:sponsorblockfrom
bravepipeproject:use-serviceId-to-determine-youtube-service

Conversation

@evermind-zz

@evermind-zz evermind-zz commented Feb 17, 2023

Copy link
Copy Markdown

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • instead of using string to determine if the youtube service is used use the serviceId

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@polymorphicshade
polymorphicshade merged commit 5c4f0f4 into polymorphicshade:sponsorblock Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants