CLI Build - clean up yarn.lock files in test cases after testing local build strategy#1384
Merged
dOrgJelli merged 6 commits intoorigin-0.10-devfrom Nov 9, 2022
Conversation
pileks
requested review from
Niraj-Kamdar,
krisbitney and
nerfZael
as code owners
2 tasks
nerfZael
approved these changes
Nov 4, 2022
Contributor
nerfZael
left a comment
nerfZael
left a comment
There was a problem hiding this comment.
We really shouldn't be using the Ethereum plugin for tests but that's a topic for another issue/PR
nerfZael
reviewed
Nov 4, 2022
…ch/clean-up-lockfiles-local-build-strategy
…f github.com:polywrap/toolchain into pileks/patch/clean-up-lockfiles-local-build-strategy
Niraj-Kamdar
approved these changes
Nov 7, 2022
dOrgJelli
approved these changes
Nov 9, 2022
dOrgJelli
deleted the
pileks/patch/clean-up-lockfiles-local-build-strategy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, I've noticed that running CLI tests (specifically the ones for the
localbuild strategy) leaves behindyarn.lockfiles inside the test case folders it operates within (currently only 001-sanity).This should ensure proper cleanup of these stray files.
Additionally, it seems that commit
28bd34a25d50824a070aaf33696a01ec64eb7ceechanged theethereumplugin's schema, which resulted in a change in the codegen output for some of thetest-caseswrappers.I have copy-pasted the updated expected files.