CLI - separate build codegen actions#1385
Merged
dOrgJelli merged 38 commits intoorigin-devfrom Jan 3, 2023
Merged
Conversation
…t/cli-separate-build-codegen-actions
…t/cli-separate-build-codegen-actions
…option to build command for when --codegen option is specified
…xecution when codegen option of CLI build command fails
pileks
requested review from
Niraj-Kamdar,
cbrzn,
dOrgJelli,
fetsorn,
krisbitney,
namesty,
nerfZael and
ramilexe
as code owners
pileks
changed the title
…t/cli-separate-build-codegen-actions
…t/cli-separate-build-codegen-actions
…-separate-build-codegen-actions
krisbitney
suggested changes
Dec 20, 2022
Contributor
krisbitney
left a comment
krisbitney
left a comment
There was a problem hiding this comment.
LGTM!
I left a couple of comments with questions. Let me know what you think. Maybe no changes are needed.
…-separate-build-codegen-actions
krisbitney
previously approved these changes
Dec 20, 2022
…-separate-build-codegen-actions
Contributor
|
Can this be merged @pileks @dOrgJelli @Niraj-Kamdar ? |
Contributor
Author
|
@krisbitney From a standpoint of implementation - Yes, it's just a matter of being reviewed! 😄 |
krisbitney
previously approved these changes
Jan 3, 2023
dOrgJelli
requested changes
Jan 3, 2023
…ild-codegen-actions chore: move plugin build logic into compiler
Contributor
Author
|
@dOrgJelli I've performed the minimal required changes to the readme just now. We can refactor the readme to use LMK if this works. |
dOrgJelli
approved these changes
Jan 3, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1365 and allows for further work on #1363 and others (namely Plugin Build Strategies, TBD).
CLI test cases will be fixed once #1384 is merged!Merged.This PR entirely separates the
buildandcodegencommand functionalities.Running
polywrap codegenon apluginproject will no longer emitwrap.infointo the./buildfolder.This PR also introduces a possible circular dependency issue, as some of our plugin projects will stop working once the newest CLI version is released.
A possible workaround for this is to have the
buildscript of each project runpolywrap codegenand continue with the build regardless of the result of the codegen, then removing it once we have the next release up.Thoughts?
Remaining work/merge prerequisites:
yarn.lockfiles in test cases after testing local build strategy #1384build:patchscript to all plugin packages which attempts to runpolywrap buildin order to output the WRAP ABI. If it fails, a message isechoed and the script exits with code 0, making the build work for the current versionpolywrapindependenciesand for the new, unreleased version. This way we won't have an interruption in the build process, and can later on write out the proper codegen/build logic (which is firstcodegenthenbuildAND make sure that both exit succesfully).