chore: move plugin build logic into compiler#1467
Merged
pileks merged 4 commits intopileks/feat/cli-separate-build-codegen-actionsfrom Jan 3, 2023
Merged
Conversation
2 tasks
pileks
approved these changes
Jan 3, 2023
Contributor
pileks
left a comment
pileks
left a comment
There was a problem hiding this comment.
Great thinking with the move to Compiler, I like it!
cbrzn
reviewed
Jan 3, 2023
cbrzn
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: there is a bit of "hacky" logic inside of the
Compilerclass. I think the best way to do this in the future is to have a baseCompilerclass, and derive it into project-specific compilers (wasm, plugin, interface). But this can be an improvement in the future IMO.