move fs interface and plugin to new repo#1495
Merged
dOrgJelli merged 8 commits intoorigin-devfrom Feb 1, 2023
Merged
Conversation
krisbitney
requested review from
Niraj-Kamdar,
cbrzn,
dOrgJelli,
namesty,
nerfZael,
pileks and
ramilexe
as code owners
cbrzn
previously approved these changes
Jan 29, 2023
…interface # Conflicts: # packages/js/client-config-builder/README.md # packages/js/client-config-builder/src/bundles/getDefaultConfig.ts # packages/js/plugins/http/src/__tests__/helpers/getClient.ts
cbrzn
approved these changes
Jan 30, 2023
dOrgJelli
approved these changes
Feb 1, 2023
Contributor
dOrgJelli
left a comment
dOrgJelli
left a comment
There was a problem hiding this comment.
@krisbitney can we make a quick issue for the remaining work of removing these workarounds so we don't forget? Also should we create a new pre-release ASAP so we can do this?
Contributor
Author
I created an issue here: #1504 I don't think we necessarily need a pre-release ASAP. I don't see it as urgent. But if it makes sense to do a release soon anyway, I'm for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of an effort to move all the interfaces and plugins outside of the toolchain repo, I moved the file-system plugin and interface to their own repo here: https://github.com/polywrap/file-system
There is a temporary import redirect added to the file-system resolver plugin. It's necessary due to circular dependencies with the CLI being used to build the package. The import redirect can be removed once the CLI in the dependencies folder incorporates the change.
There is also a temporary extra redirect added to avoid breaking changes: