Fix: top-level docker property is now removed from build manifest during migration#1692
Merged
dOrgJelli merged 2 commits intoorigin-devfrom Apr 17, 2023
Merged
Conversation
krisbitney
requested review from
Niraj-Kamdar,
dOrgJelli,
namesty,
nerfZael and
pileks
as code owners
… project manifest migrator 0.2.0_to_0.3.0.ts
dOrgJelli
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the top-level
dockerproperty of build manifest version 0.1.0 was not being dropped during migration, causing migrated build manifests to fail validation.I added too much detail to the issue I created for this, before realizing I could the bug in less time than it took to create the issue 😂. Check it out for more information: #1691
Closes #1691
I also fixed an issue where removal of extensions in the project manifest could lead to an empty object assigned to the
extensionsproperty.