Skip to content

Fix: top-level docker property is now removed from build manifest during migration #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dOrgJelli merged 2 commits into from
Apr 17, 2023
Merged

Fix: top-level docker property is now removed from build manifest during migration #1692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74848f4
removed top-level docker property during build manifest migration
krisbitney Apr 14, 2023
49390a2
removed possibility of empty object assigned to extension property in…
krisbitney Apr 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/js/manifests/polywrap/src/formats/polywrap.build/migrators/0.1.0_to_0.2.0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import { BuildManifest as NewManifest } from "../0.2.0";

export function migrate(old: OldManifest): NewManifest {
return {
...old,
config: old.config,
linked_packages: old.linked_packages,
__type: "BuildManifest",
format: "0.2.0",
strategies: {
Expand Down
6 changes: 5 additions & 1 deletion packages/js/manifests/polywrap/src/formats/polywrap/migrators/0.2.0_to_0.3.0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { ILogger } from "@polywrap/logging-js";
import { PolywrapManifest as OldManifest } from "../0.2.0";
import { PolywrapManifest as NewManifest } from "../0.3.0";

import { ILogger } from "@polywrap/logging-js";

export function migrate(migrate: OldManifest, logger?: ILogger): NewManifest {
if (migrate.extensions?.meta) {
logger?.warn(
Expand All @@ -21,8 +22,11 @@ export function migrate(migrate: OldManifest, logger?: ILogger): NewManifest {
);
delete migrate.extensions.infra;
}
const hasExtensions =
migrate.extensions && Object.keys(migrate.extensions).length > 0;
return {
...migrate,
format: "0.3.0",
extensions: hasExtensions ? migrate.extensions : undefined,
};
}