Skip to content

Static Pages deploy currently bakes in placeholder .env-sample content #5

Description

@michielbdejong

Problem

.github/workflows/static.yml runs npm run setup, which copies .env-sample to .env if none exists (per the README). That sample file has several placeholder values, e.g.:

OLSK_APROPOS_FEEDBACK_EMAIL="XXXXX"
KVC_VITRINE_GLOSSARY_WRITING_USING_URL="XXXXX"
KVC_VITRINE_GLOSSARY_PUBLIC_REF_URL="XXXXX"

These get baked into the statically-rendered pages at build time (e.g. the feedback link becomes mailto:XXXXX). Fine for verifying the pipeline works end-to-end (which is what I did for #1), but not for a real public deployment.

Suggested next steps

  • Populate the real values as repository secrets/variables
  • Add a step in static.yml before npm run build that writes a real .env from those secrets, instead of relying on the .env-sample fallback

https://claude.ai/code/session_01AcjKc8vk2fb84yYZsE8k5d

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions