Skip to content

Define custodial escrow subtype - #4

Merged
okjodom merged 1 commit into
mainfrom
ok/pip01-custodial-escrow
Jun 1, 2026
Merged

Define custodial escrow subtype#4
okjodom merged 1 commit into
mainfrom
ok/pip01-custodial-escrow

Conversation

@okjodom

@okjodom okjodom commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add custodial_escrow as a canonical PIP-01 subtype
  • keep top-level networks as the canonical supported-network declaration
  • define common custodial fields: custody_authority, release_authority, and refund_authority
  • align release/refund conditions with nested release_rules.release_trigger and release_rules.refund_trigger
  • add network-specific implementations guidance and a Lightning custodial invoice example

Closes #3

Verification

  • git diff --check
  • stale reference scan for removed MIP/Minmo/protocol-overview/.skills references

Copilot AI review requested due to automatic review settings June 1, 2026 16:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the PIP-01 escrow descriptor specification by introducing a new canonical subtype, custodial_escrow, to describe operator-custodied escrow flows while preserving the existing top-level networks field as the canonical supported-network declaration.

Changes:

  • Adds a new canonical subtype section: custodial_escrow, including common custodial authority fields and lifecycle guidance.
  • Defines an implementations array for network-specific implementation profiles constrained to the declared networks.
  • Updates the “Open Question” note to include custodial_escrow alongside lightning_hold_invoice.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PIP-01-escrow-descriptor.md Outdated
Comment thread PIP-01-escrow-descriptor.md Outdated
Comment thread PIP-01-escrow-descriptor.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define custodial_escrow as a canonical PIP-01 subtype

2 participants