Fix skip inside terminal producing empty tokens - #91
Merged
Conversation
When a skip operator appeared inside a terminal, the skipped bytes were not accumulated into the token's span. Sequence and Many both dropped Skipped results with nonzero advance in their token-mode parsing, and Terminal itself did not handle Skipped results reaching it through Choice. Closes #20
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a skip operator appeared inside a terminal, the skipped bytes were not accumulated into the token's span.
Sequence._parse_tokenandMany._parse_tokenboth groupedSkippedwithNotPresentin a match arm constrained to zero advance, so a skip that consumed bytes fell through to the failure path.Terminal.parsehad noSkippedarm at all, so aSkippedresult reaching it throughChoicealso failed.All three sites now handle
Skippedwith nonzero advance:SequenceandManyaccumulate it into the token length, andTerminaltreats it the same asLex.Closes #20