Fix unproven peer certificates reporting SSLError instead of SSLAuthFail - #133
Merged
Conversation
The existing checks in _peer_auth_failed — chain verification result and error queue scan — miss the case where a peer presents a certificate it cannot prove it holds. The chain verifies (the certificate is genuine), no "no certificate" reason appears on the queue, and the error codes for the signature failure differ across OpenSSL and LibreSSL. After the existing checks, a non-null peer certificate means the handshake failed after the peer's credentials were received. That is an authentication failure regardless of which error code the backend used. Closes #132
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing checks in
_peer_auth_failed— chain verification result and error queue scan — miss the case where a peer presents a certificate it cannot prove it holds. The chain verifies (the certificate is genuine), no "no certificate" reason appears on the queue, and the error codes for the signature failure differ across OpenSSL and LibreSSL.After the existing checks, a non-null peer certificate means the handshake failed after the peer's credentials were received. That is an authentication failure regardless of which error code the backend used.
A peer whose certificate will not parse remains
SSLError— the failure happens before chain verification, so it is not distinguishable from one that had nothing to do with a certificate.Closes #132