Fix read and alpn_selected returning data from authentication-failed sessions - #136
Merged
Merged
Conversation
ponylang-main
added
the
discuss during sync
SeanTAllen
changed the title
SeanTAllen
added
the
changelog - fixed
…sessions Calling `read` on a session in `SSLAuthFail` overwrote the state with `SSLError`, so code that branched on the state to distinguish authentication failures from other errors lost the distinction after the first `read`. Calling `alpn_selected` on the same session returned the ALPN protocol the rejected peer had negotiated. Calling `receive` accepted ciphertext from a peer whose identity had been rejected. Guard all three methods so they return immediately when the session has already failed: `read` and `alpn_selected` return `None`, and `receive` does nothing. `receive` also guards against `SSLError`, since feeding ciphertext into a session that has failed for any reason is pointless. Closes #125
SeanTAllen
force-pushed
the
fix-read-and-alpn-auth-fail-guard
branch
from
August 2, 2026 00:59
208b3ac to
3fef24f
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL.readon a session inSSLAuthFailcalledSSL_read, which returned an error that overwrote_statewithSSLError-- losing the distinction between an authentication failure and any other SSL-layer error.SSL.alpn_selectedreturned the peer-supplied ALPN protocol from the same failed session.SSL.receiveaccepted ciphertext from a peer whose identity had been rejected.Guard all three methods so they return immediately when the session has already failed.
receivealso guards againstSSLError, since feeding ciphertext into a session that has failed for any reason is pointless.Closes #125