Fix ssl/net silently losing data past two gibibytes - #138
Merged
Conversation
Four methods in SSL narrowed a USize to I32 without checking. Past I32.max_value the conversion wraps, so write and receive silently dropped data, send returned uninitialized memory, and read over-allocated its buffer. write and receive now loop in chunks that fit in a C int. read and send cap the per-call length and let their callers' existing loops drain the rest. Closes #121
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four methods in
SSLnarrowed aUSizetoI32without checking. PastI32.max_value()the conversion wraps, sowriteandreceivesilently dropped data,sendreturned uninitialized memory, andreadover-allocated its buffer.writeandreceivenow loop in chunks that fit in a Cint.readandsendcap the per-call length and let their callers' existing loops drain the rest.Closes #121