Fix SSL.write silently losing data when encryption fails - #139
Merged
Conversation
SSL.write discarded SSL_write's return value, so it reported success when it encrypted nothing. write now checks the return, distinguishes fatal from transient errors, and raises on failure. Closes #122
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL.writediscardedSSL_write's return value, so it reported success even when the call encrypted nothing. A TLS 1.2 peer that started a renegotiation hit this: the session was stillSSLReady,SSL_writereturnedSSL_ERROR_WANT_READ, and the payload was gone with no signal to the caller.writenow checksSSL_write's return value and raises on failure. Fatal errors (SSL_ERROR_SSL,SSL_ERROR_SYSCALL,SSL_ERROR_ZERO_RETURN) set_state = SSLError; a transientSSL_ERROR_WANT_READraises without changing state. The error dispatch mirrorsread().All three callers in
SSLConnectionalready wrapwriteintry/else, so no caller changes are needed.Closes #122