Reject inverted protocol version range in SSLContext - #142
Merged
Conversation
OpenSSL validates each boundary individually but does not cross-check min against max. A caller could set min above max without raising, producing a context where every session fails its handshake. Both setters now compare the new value against the existing opposite boundary before calling SSL_CTX_ctrl, so the context is never left with an inverted range. SSLAutoVersion (0) bypasses the check, since a zero boundary means the library picks. Closes #129
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_min_proto_versionandset_max_proto_versionaccepted an inverted range — min above max — without raising. OpenSSL validates each boundary individually but does not cross-check them, so the call succeeded and every session from that context failed its handshake with "no protocols available."Both setters now compare the new value against the existing opposite boundary before calling
SSL_CTX_ctrl.SSLAutoVersion(0) bypasses the check, since a zero boundary means the library picks.Closes #129