Replace state polling with return values from receive, read, and send - #152
Merged
Conversation
ponylang-main
added
the
discuss during sync
SeanTAllen
added a commit
that referenced
this pull request
Aug 5, 2026
Member
Author
|
No outstanding parked items. |
SeanTAllen
added a commit
that referenced
this pull request
Aug 5, 2026
PR #152's Changed entry covers SSLClosed as a read() return value. The internal OpenSSL constant doesn't belong in user-facing text.
receive(), read(), and send() now return what happened instead of requiring the caller to poll state() afterwards. state(), can_send(), SSLState, SSLHandshake, and SSLDisposed are removed. InvalidOperation signals a call on a session that is no longer operational (disposed). SSLReceiveOK is renamed to SSLAccepted. Closes #150
SeanTAllen
force-pushed
the
tell-dont-ask
branch
from
August 6, 2026 00:27
a4b1b2a to
242bfa0
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
receive(),read(), andsend()now return what happened instead of requiring the caller to pollstate()afterwards.state(),can_send(),SSLState,SSLHandshake, andSSLDisposedare removed.receive()returnsSSLReceiveResult—SSLReceiveOKwhen data was accepted with nothing else to report,SSLReadywhen the handshake completes,SSLAuthFailorSSLErroron failure.read()returnsSSLReadResult— application data,None,SSLClosed, orSSLError.send()returns(Array[U8] iso^ | None)and no longer raises.SSLConnectionuses return values from each operation to drive its callbacks instead of polling state.Closes #150