Skip to content

xml 소문자 -> 대문자 변경 및 로그 관련 의존성 추가 및 몽고디비 연결#148

Merged
ms-0o0 merged 14 commits into
mainfrom
dev
Mar 10, 2026
Merged

xml 소문자 -> 대문자 변경 및 로그 관련 의존성 추가 및 몽고디비 연결#148
ms-0o0 merged 14 commits into
mainfrom
dev

Conversation

@hyuuuun
Copy link
Copy Markdown
Contributor

@hyuuuun hyuuuun commented Mar 10, 2026

개요

xml 소문자 -> 대문자 변경

  • line
  • noti
  • question

로그 관련 의존성 추가

  • 로그 템플릿
  • 프로메테우스 마이크로미터

몽고 db 설정

  • 몽고 db 연결

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

  • [] 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • [] 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

PR Checklist

  • 커밋 메시지 컨벤션에 맞게 작성했습니다.
  • 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

  • New Features

    • Added batch alarm notification creation to send alarms to multiple recipients at once
  • Chores

    • Added Prometheus monitoring and structured logging infrastructure
    • Integrated MongoDB database support
    • Enhanced error tracking with request trace identifiers
    • Added test data generation utilities

@hyuuuun hyuuuun requested review from hyeonRS and ms-0o0 March 10, 2026 07:56
@hyuuuun hyuuuun self-assigned this Mar 10, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 10, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The changes add test data generation infrastructure with scripts and documentation, integrate monitoring dependencies (Prometheus, Logstash, MongoDB), implement request-level tracing with MDC, add batch alarm creation to the notification service, and standardize database table references to uppercase across MyBatis mapper files.

Changes

Cohort / File(s) Summary
Test Data Infrastructure
.gitignore, scripts/test-data/README.md, scripts/test-data/generate_profiles.sh, scripts/test-data/generate_test_data_csv.py
New test data generation system including documentation, profile-based shell script for generating datasets at various scales (n100 to n1000000), and Python script for generating comprehensive CSV test data with synthetic users, alarms, families, and usage records.
Dependencies and Configuration
build.gradle, src/main/resources/application-local.yml, src/main/resources/application.yaml
Added Prometheus registry, Logstash encoder, and MongoDB dependencies; configured MongoDB connection URI, Logback logging configuration path, and management endpoints exposure for health and Prometheus metrics.
Request Logging and Tracing
src/main/java/com/pooli/common/filter/LoggingFilter.java, src/main/java/com/pooli/common/exception/GlobalExceptionHandler.java, src/main/resources/monitoring/logback-spring.xml
New LoggingFilter for per-request traceId generation and MDC management; enhanced GlobalExceptionHandler to log with traceId context; added Logback configuration with ConsoleAppender using LogstashEncoder for structured JSON logging.
Notification Service Enhancement
src/main/java/com/pooli/notification/service/AlarmHistoryService.java, src/main/java/com/pooli/notification/service/AlarmHistoryServiceImpl.java
Added new createListAlarm method supporting batch alarm creation with target type handling (DIRECT, ALL, OWNER, MEMBER), validation, deduplication, and JSON payload construction for multiple recipients.
Database Mapper Table Name Standardization
src/main/resources/mapper/line/LineMapper.xml, src/main/resources/mapper/notification/AlarmHistoryMapper.xml, src/main/resources/mapper/notification/AlarmSettingMapper.xml, src/main/resources/mapper/notification/NotificationLineMapper.xml, src/main/resources/mapper/question/AnswerMapper.xml, src/main/resources/mapper/question/QuestionMapper.xml
Standardized all table references from lowercase to uppercase (e.g., lineLINE, alarm_settingALARM_SETTING) across SELECT, INSERT, UPDATE, and JOIN statements without altering column names or query logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

refactor


🐰 Logs flow like carrots in a stream,
Batch alarms wake up the team,
Tables stand tall in uppercase pride,
Test data swells on the data ride,
Traces dance through MDC's gleam!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main changes: XML table reference casing updates, logging-related dependencies, and MongoDB configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ms-0o0 ms-0o0 merged commit 2d36c56 into main Mar 10, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants