Conversation
- uuid 중복이 생길 수 있음 - /api/auth/ 요청 redacted 처리 - password, token, accessToken, refreshToken, authorization, cookie, secret, credential 자동 마스킹 - 정상 응답(2xx/3xx): body 미출력 - GlobalExceptionHandler용 캐시(cachedRequestBody) 유지
524 monitoring log
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR consolidates request logging functionality by merging RequestLoggingFilter into an enhanced LoggingFilter with structured MDC logging, sensitive data masking, and conditional body logging. It removes the separate RequestLoggingFilter class and simplifies GlobalExceptionHandler. Additionally, it introduces new MyBatis query metrics collection via a custom interceptor integrated with Micrometer. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant LoggingFilter
participant SQLExecutor as MyBatis SQL<br/>Executor
participant MybatisMetricsInterceptor
participant MybatisQueryMetrics
participant MeterRegistry
Client->>LoggingFilter: HTTP Request
LoggingFilter->>SQLExecutor: Process & Pass Request
SQLExecutor->>MybatisMetricsInterceptor: Execute Query
MybatisMetricsInterceptor->>MybatisMetricsInterceptor: Extract mapper & operation<br/>from statementId
MybatisMetricsInterceptor->>MybatisMetricsInterceptor: Measure execution<br/>duration
MybatisMetricsInterceptor->>MybatisQueryMetrics: record(mapper, operation, duration)
MybatisQueryMetrics->>MybatisQueryMetrics: Build cache key:<br/>mapper.operation
MybatisQueryMetrics->>MybatisQueryMetrics: Create/retrieve Timer<br/>with tags
MybatisQueryMetrics->>MeterRegistry: Register Timer
MybatisQueryMetrics->>MeterRegistry: Record duration
MeterRegistry-->>MybatisQueryMetrics: Metrics stored
MybatisMetricsInterceptor-->>SQLExecutor: Return result
SQLExecutor-->>LoggingFilter: Query complete
LoggingFilter->>LoggingFilter: Log request with MDC fields
LoggingFilter-->>Client: HTTP Response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ms-0o0
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
관련 BackLog
Resolves: (Backlog Number, ...)
PR 유형
PR Checklist
Summary by CodeRabbit
New Features
Chores