Night Light (feature)

[CyphrRiot]

I built a working Night Light and have a complete implementation of the Night Light feature with:

1. A gamma adjustment manager in cosmic-comp that handles the actual color temperature changes
2. An enhanced Night Light service that supports:
   • Basic enable/disable functionality
   • Temperature adjustment
   • Scheduled activation (both automatic based on sunset/sunrise and manual scheduling)
   • Location-based sunset/sunrise calculation
   • Configuration persistence
   • Smooth temperature transitions
3. An improved UI that provides controls for:
   • Enabling/disabling Night Light
   • Adjusting color temperature
   • Setting up schedules (automatic or manual)
   • Configuring location for sunset/sunrise calculation
   • Setting manual schedule times

I am putting together diffs and will share it with the team. I am hoping it gets used (or integrated with their version), because Night Light is the only thing keeping me from using Cosmic full-time.

[CyphrRiot]

1. Defined Night Light messages and state in the settings app
2. Created a Night Light service that handles DBus communication
3. Updated the app to handle Night Light messages

Completed:

1. Added gamma management to cosmic-comp ✓
2. Connected Night Light service with Gamma Manager ✓
3. Added necessary dependencies ✓
4. Updated message handling in settings app ✓

The Night Light feature is now fully implemented with:

• An easily accessible toggle in settings
• Temperature adjustment
• Automatic scheduling based on location
• Manual schedule option
• Smooth transitions
• Configuration persistence
• DBus communication between components

Here's the patch file: cosmic-epoch-unified.patch

Update: The patch is for reference. Working on a pull request.

[mmstick]

You need to create pull requests for code reviews and merges.

[Drakulix]

Also: pop-os/cosmic-comp#2059

[claybford]

I'd add a configurable key combo to switch the night light on/off as a requirement.

[zaa94]

@HunterR0se Have you submitted a PR for this yet?

[ArthurPavezzi]

@HunterR0se Have you submitted a PR for this yet?

[cposinoff]

what gives 'hoss ? ;)

[CyphrRiot]

I won't be able to submit a PR for this anytime soon. Someone else will have to do so unless you're willing to wait. The Cosmic Desktop git repo is incredibly complicated and keeps changing and I'm buried in other work at the moment. 😢

[shocklateboy92]

Here's the patch file: cosmic-epoch-unified.patch

Update: The patch is for reference. Working on a pull request.

@CyphrRiot that link is now dead. Could you re-upload the patch somewhere? I can look into rebasing and creating a pull request.

[yemethist]

@shocklateboy92 Found an archived version of their patch: cosmic-epoch-unified.patch

[WizardlyMeow]

Would also love to see this implemented soon

[shocklateboy92]

@shocklateboy92 Found an archived version of their patch: cosmic-epoch-unified.patch

Okay, I took a look through that patch and unfortunately, it is unusable. The diff appears to have been taken against a base that's different from the commit they started their work on, making it very difficult to pinpoint the relevant changes 🫤

But as far as I can tell, the GammaManager::apply_gamma function ends with a:

+                    // Apply gamma ramps
+                    if let Some(wl_output) = output.get_wayland_output() {
+                        // TODO: Apply gamma via wlroots/smithay
+                        // This requires implementing the necessary gamma interfaces
+                    }

[shocklateboy92]

Okay, I've decided to try implementing it from scratch here:
pop-os/cosmic-comp#1543

[Areopagitics]

@shocklateboy92 what's the progress on this? It looks like there is a page in the cosmic settings, but it's just not enabled. Is there a work around to enable it at the moment?