Skip to content

Remove unittest in favour of pytest.#315

Merged
grahamgower merged 4 commits intopopsim-consortium:mainfrom
grahamgower:tests
Jun 4, 2021
Merged

Remove unittest in favour of pytest.#315
grahamgower merged 4 commits intopopsim-consortium:mainfrom
grahamgower:tests

Conversation

@grahamgower
Copy link
Copy Markdown
Member

Closes #210.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2021

Codecov Report

Merging #315 (02c0027) into main (a040a4f) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   99.78%   99.91%   +0.13%     
==========================================
  Files           5        4       -1     
  Lines        1397     1245     -152     
==========================================
- Hits         1394     1244     -150     
+ Misses          3        1       -2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a040a4f...02c0027. Read the comment docs.

Copy link
Copy Markdown
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromekelleher
Copy link
Copy Markdown
Member

Do we have dev docs to update?

@grahamgower
Copy link
Copy Markdown
Member Author

Do we have dev docs to update?

There's nothing in the dev docs that mentioned unittest.TestCase. Is there something else you had in mind?

@grahamgower grahamgower marked this pull request as ready for review June 4, 2021 08:40
@grahamgower grahamgower merged commit a043b2c into popsim-consortium:main Jun 4, 2021
@grahamgower grahamgower deleted the tests branch June 4, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convert tests away from using unittest.TestCase, and use pytest directly

2 participants