Skip to content

Fix deme.size_at(deme.start_time).#428

Merged
grahamgower merged 1 commit intopopsim-consortium:mainfrom
grahamgower:size_at
Feb 27, 2022
Merged

Fix deme.size_at(deme.start_time).#428
grahamgower merged 1 commit intopopsim-consortium:mainfrom
grahamgower:size_at

Conversation

@grahamgower
Copy link
Copy Markdown
Member

Closes #427.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2022

Codecov Report

Merging #428 (7b0299c) into main (a34be5c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files           5        5           
  Lines        1552     1554    +2     
=======================================
+ Hits         1549     1551    +2     
  Misses          3        3           
Impacted Files Coverage Δ
demes/demes.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34be5c...7b0299c. Read the comment docs.

Copy link
Copy Markdown
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good approach. Let's see if @molpopgen and @apragsdale agree.

@apragsdale
Copy link
Copy Markdown
Member

apragsdale commented Feb 17, 2022 via email

@molpopgen
Copy link
Copy Markdown
Collaborator

I'll be back at work next Tuesday or Wednesday.

@molpopgen
Copy link
Copy Markdown
Collaborator

This looks good to me! Sorry for the slow reply.

@grahamgower grahamgower merged commit fa09c0f into popsim-consortium:main Feb 27, 2022
@grahamgower grahamgower deleted the size_at branch May 24, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deme.size_at(t) returns value when t == start_time

4 participants