fix AttributeError exception if process.completion_engine is None #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisri
reviewed
Oct 28, 2025
| process.completion_engine.process = weak_proxy( | ||
| process, process.completion_engine._clear_node) | ||
| return process.completion_engine | ||
| if ce and ce.process is not process: |
There was a problem hiding this comment.
I think != was here intentionally instead of is not, because the process may be a Process instance or a weakref or a weak proxy, and is not would be True if the same process is compared across a proxy. I'm not sure of that.
There was a problem hiding this comment.
Oh yes, I hadn't thought about the weak proxy case! I think you're absolutely right. I'll change ‘is not’ to ‘!=’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a recent commit in capsul (cb21ec4), the Mia tests are failing.
In Mia, we do not use the completion engine (and I do not know how it works!), and process.completion_engine is None.
I therefore propose a small fix in capsul to handle cases where process.completion_engine exists but the value is None.
I did not commit it directly because I do not know if this change could introduce a regression as a side effect... so I opened this PR instead.