Skip to content

fix AttributeError exception if process.completion_engine is None #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2025
Merged

fix AttributeError exception if process.completion_engine is None #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0047271
fix AttributeError exception if process.completion_engine is None
servoz Oct 27, 2025
722fb35
same thing in completion_engine module
servoz Oct 27, 2025
4f325ab
Fix comparison operator in completion engine factory
servoz Oct 29, 2025
c3da87c
Fix comparison operator in completion_engine.py
servoz Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions capsul/attributes/completion_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,11 +987,11 @@ def get_completion_engine(self, process, name=None):
instance, which is quite incomplete.
'''
if hasattr(process, 'completion_engine'):
ce = process.completion_engine
# just in case the process has been changed in the CE
if process.completion_engine.process != process:
process.completion_engine.process = weak_proxy(
process, process.completion_engine._clear_node)
return process.completion_engine
if ce and ce.process != process:
ce.process = weak_proxy(process, ce._clear_node)
return ce

if isinstance(process, Switch):
return SwitchCompletionEngine(process, name=name)
Expand Down
8 changes: 4 additions & 4 deletions capsul/attributes/completion_engine_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ def get_completion_engine(self, process, name=None):
conform to the API.
'''
if hasattr(process, 'completion_engine'):
ce = process.completion_engine
# just in case the process has been changed in the CE
if process.completion_engine.process != process:
process.completion_engine.process = weak_proxy(
process, process.completion_engine._clear_node)
return process.completion_engine
if ce and ce.process != process:
ce.process = weak_proxy(process, ce._clear_node)
return ce

study_config = process.get_study_config()

Expand Down
Loading