Update working directory for dotnet workflow steps#3
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the GitHub Actions .NET workflow to use a valid working directory for restore/build/test steps.
Changes:
- Updates
working-directoryfrom a solution file path to theSrcdirectory for restore/build/test steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Restore dependencies | ||
| run: dotnet restore | ||
| working-directory: Src/System.DisposableObject.sln | ||
| working-directory: Src | ||
| - name: Build | ||
| run: dotnet build --no-restore | ||
| working-directory: Src/System.DisposableObject.sln | ||
| working-directory: Src | ||
| - name: Test | ||
| run: dotnet test --no-build --verbosity normal | ||
| working-directory: Src/System.DisposableObject.sln | ||
| working-directory: Src |
There was a problem hiding this comment.
Switching working-directory to Src fixes the invalid directory issue, but the commands no longer explicitly target System.DisposableObject.sln. If Src contains multiple projects/solutions, dotnet restore/build/test may run against an unintended target or fail due to ambiguity. Consider invoking the solution explicitly (e.g., pass System.DisposableObject.sln to restore/build/test) while keeping working-directory: Src, or set run: to use the solution path from the repo root (and drop working-directory).
No description provided.