Skip to content

Update working directory for dotnet workflow steps #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
porrey merged 1 commit into from
Apr 21, 2026
Merged

Update working directory for dotnet workflow steps #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
dotnet-version: 10.0.x
- name: Restore dependencies
run: dotnet restore
working-directory: Src/System.DisposableObject.sln
working-directory: Src
- name: Build
run: dotnet build --no-restore
working-directory: Src/System.DisposableObject.sln
working-directory: Src
- name: Test
run: dotnet test --no-build --verbosity normal
working-directory: Src/System.DisposableObject.sln
working-directory: Src
Comment on lines 23 to +31
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching working-directory to Src fixes the invalid directory issue, but the commands no longer explicitly target System.DisposableObject.sln. If Src contains multiple projects/solutions, dotnet restore/build/test may run against an unintended target or fail due to ambiguity. Consider invoking the solution explicitly (e.g., pass System.DisposableObject.sln to restore/build/test) while keeping working-directory: Src, or set run: to use the solution path from the repo root (and drop working-directory).

Copilot uses AI. Check for mistakes.