Fix live angle previews and improve LLM authoring guidance - #117
Merged
Conversation
Signed-off-by: a-baran-orhan <a.baranorhan@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a-baran-orhan
marked this pull request as ready for review
August 1, 2026 18:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The parser and renderer already honored edited angles, but every successful edit reloaded the timeline at time zero and immediately resumed playback. Fast phases such as the front kick's 0.5-second chamber made valid edits appear to have no effect. Direct angle edits now carry their source line through recompilation, resolve that line to its phase, and hold the corresponding key pose for immediate visual feedback.
Impact
Changing an inline angle control, for example
knee_right: flex 90to10, now jumps to and holds the edited pose. LLMs also receive more precise, product-specific instructions designed to prevent invented syntax, invalid contact combinations, contradictory cues, and accidental loop resets.Validation
npx vitest run --exclude playground/test/positioning.test.ts— 429 tests passednpm run typechecknpm run buildThe excluded positioning test is affected only by unrelated, uncommitted landing-page work in the local worktree; those files are not part of this PR.