Improve contact-aware motion quality - #31
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a-baran-orhan
marked this pull request as ready for review
July 11, 2026 07:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The renderer was interpolating sparse poses while pins only translated the root toward averaged contact points. This allowed both hands to target one bar point, left wrists without a surface orientation, authored toe-heavy squats, and let mocap overwrite already-solved contacts.
Impact
Pull-ups now use separate hand positions and visible cylindrical grips, grounded squat-family movements keep their feet flat, and mocap-driven motion retains solved contacts. Existing Posecode syntax remains compatible.
Validation
npm test— 214/214 tests passednpm run typecheck— passednpm run build— passednpm run eval— 814/814 checks across 73 movements, with no parse failures or clamp warnings