Conversation
|
I think we should definitely describe the new input formats. I wouldn't describe them as "half-baked". It's definitely a cool new feature that Poseidon packages can have zipped files. People can just manually zip them if they want. I think whether or not two specific sub-commands ( I am happy to suggest that change to this PR. Thanks for remembering to update the Webpage. |
|
Speaking about it, I think this feature-set also justifies a blog-post, which I'll try to use meeting-free week for as well. |
|
I'm skeptical, Stephan. As long as the writing is not there I see few practical use-cases. And the documentation of these features will be easier when they are complete, because they can just be added to the list of supported file formats. Remember to move the old v1.5.4.0 documentation to the archive when you create the new v1.5.7.0 version. |
|
OK, I've made the changes. How can I trigger the add_pdf workflow? I am happy to talk in person why I think writing of VCFs and zipped files is a minor detail as opposed to reading. |
|
You convinced me that this update is sensible 👍 The .pdf generation should be triggered automatically when merging into the master branch, if the new archive document was added to the pdf_conversion_list.tsv. Beyond the changes you already made I think we also have to include the |
stschiff
left a comment
There was a problem hiding this comment.
Sorry, I thought I'd already reviewed this. Looks all good. Good to merge, sorry for the delay!
Minimal update for v1.5.7.0.
@stschiff I'm not sure if we should describe the reading of gzipped archives and .vcf files already. At the moment both features are half-baked (no writing) and experimental. What do you think?