Skip to content

trident v1.5.7.3#76

Merged
nevrome merged 4 commits intomasterfrom
trident1570
Nov 13, 2024
Merged

trident v1.5.7.3#76
nevrome merged 4 commits intomasterfrom
trident1570

Conversation

@nevrome
Copy link
Copy Markdown
Member

@nevrome nevrome commented Oct 26, 2024

Minimal update for v1.5.7.0.

@stschiff I'm not sure if we should describe the reading of gzipped archives and .vcf files already. At the moment both features are half-baked (no writing) and experimental. What do you think?

@stschiff
Copy link
Copy Markdown
Member

I think we should definitely describe the new input formats. I wouldn't describe them as "half-baked". It's definitely a cool new feature that Poseidon packages can have zipped files. People can just manually zip them if they want. I think whether or not two specific sub-commands (forge and genoconvert) can write them is independent.

I am happy to suggest that change to this PR. Thanks for remembering to update the Webpage.

@stschiff
Copy link
Copy Markdown
Member

Speaking about it, I think this feature-set also justifies a blog-post, which I'll try to use meeting-free week for as well.

@nevrome
Copy link
Copy Markdown
Member Author

nevrome commented Oct 28, 2024

I'm skeptical, Stephan. As long as the writing is not there I see few practical use-cases. And the documentation of these features will be easier when they are complete, because they can just be added to the list of supported file formats.

Remember to move the old v1.5.4.0 documentation to the archive when you create the new v1.5.7.0 version.

@stschiff
Copy link
Copy Markdown
Member

OK, I've made the changes. How can I trigger the add_pdf workflow?

I am happy to talk in person why I think writing of VCFs and zipped files is a minor detail as opposed to reading.

@nevrome
Copy link
Copy Markdown
Member Author

nevrome commented Oct 29, 2024

You convinced me that this update is sensible 👍

The .pdf generation should be triggered automatically when merging into the master branch, if the new archive document was added to the pdf_conversion_list.tsv.

Beyond the changes you already made I think we also have to include the --vcffile option to the command line documentation of most other subcommands, not just init.

@nevrome nevrome changed the title trident v1.5.7.0 trident v1.5.7.3 Nov 5, 2024
Copy link
Copy Markdown
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I'd already reviewed this. Looks all good. Good to merge, sorry for the delay!

@nevrome nevrome merged commit 4953114 into master Nov 13, 2024
@nevrome nevrome deleted the trident1570 branch November 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants