Alias the @types/vscode devDependency to @types/positron-vscode - #27
Merged
Conversation
Workspace consumers (Positron, Posit Assistant) hoist the packages' devDependencies into their root node_modules. At its real name the package occupies the node_modules/@types/vscode path, so a host that provides the vscode API as an ambient module (Positron core) resolves 'import ... from vscode' to the stale DefinitelyTyped copy instead, producing duplicate-identifier errors. Positron currently works around this by deleting the package in its postinstall. Under the alias, module resolution never consults the package; the tsconfigs include its ambient 'declare module vscode' explicitly via the types array, the pattern tsconfig.declarations.json and tsconfig.positron.json already used.
wch
approved these changes
Jul 23, 2026
melissa-barca
added a commit
to posit-dev/positron
that referenced
this pull request
Jul 23, 2026
ai-lib cb28d1d renames its @types/vscode devDependency to the aliased @types/positron-vscode (posit-dev/ai-lib#27), so the hoisted package no longer occupies node_modules/@types/vscode and core's 'vscode' imports bind to the ambient src/vscode-dts/vscode.d.ts without help. Remove pruneRootVscodeTypes() and its calls; the pin also picks up ai-lib #24-#26 (bridge build-coordinator changes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Positron and Posit Assistant build these packages as workspace members, so npm hoists their devDependencies into the consuming repo's root
node_modules. At its real name the package occupiesnode_modules/@types/vscode, and in Positron core, which provides the vscode API as an ambient module fromsrc/vscode-dts/vscode.d.ts, everyimport ... from 'vscode'then resolves to the DefinitelyTyped copy instead, producing duplicate-identifier errors across the program.Renames the devDependency to
"@types/positron-vscode": "npm:@types/vscode@^1.100.0"and points the tsconfigtypesarrays at the aliased name, so the hoisted copy sits on a path that module resolution for'vscode'never consults. The DefinitelyTyped package is a single ambientdeclare module 'vscode', so atypesentry includes it without module-path resolution;tsconfig.declarations.jsonandtsconfig.positron.jsonalready consumed it that way.Verified with build, check-types (including the typechecks shape guard), tests, and lint. In Positron, a fresh compile of core and all built-in extensions with the aliased package hoisted to the root and
@types/vscodeabsent reports 0 errors.