New help proxy server#107
Merged
Merged
Conversation
softwarenerd
requested review from
DavisVaughan,
jmcphers,
kevinushey and
petetronic
and removed request for
kevinushey
October 4, 2023 00:53
DavisVaughan
approved these changes
Oct 4, 2023
DavisVaughan
reviewed
Oct 4, 2023
…wed for i32 and u16
…ing them as strings
lionel-
requested changes
Oct 5, 2023
lionel-
left a comment
lionel-
left a comment
Contributor
There was a problem hiding this comment.
The new help highlighting looks great!
I just have some concerns about the conversion method.
DavisVaughan
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the lack of theming for R help by replacing the
help_proxyserver with a new one that provides themed replacements forR.cssandprism.css.Light theme:
Dark theme: