(6) Goto definition tests for workspace package import() and importFrom()#1304
Merged
Merged
Conversation
lionel-
approved these changes
Jul 2, 2026
| @@ -0,0 +1,45 @@ | |||
| use std::path::Path; | |||
|
|
|||
| /// Assembles a `DESCRIPTION` file from parts | |||
Comment on lines
+272
to
+279
| DescriptionWriter::new() | ||
| .package("mypackage") | ||
| .version("0.0.0") | ||
| .imports(&["foopkg"]) | ||
| .write(workspace.path()); | ||
| NamespaceWriter::new() | ||
| .import("foopkg") | ||
| .write(workspace.path()); |
DavisVaughan
force-pushed
the
feature/sources-5-delete-oak-sources
branch
from
July 2, 2026 18:27
e67e4ef to
89143f3
Compare
DavisVaughan
force-pushed
the
feature/sources-6-goto-definition-tests
branch
from
July 2, 2026 18:27
e719a6a to
0b36e63
Compare
DavisVaughan
force-pushed
the
feature/sources-5-delete-oak-sources
branch
from
July 2, 2026 18:31
89143f3 to
b610b37
Compare
DavisVaughan
force-pushed
the
feature/sources-6-goto-definition-tests
branch
from
July 2, 2026 18:32
0b36e63 to
4c919a6
Compare
DavisVaughan
force-pushed
the
feature/sources-5-delete-oak-sources
branch
from
July 2, 2026 18:42
b610b37 to
8c5acb7
Compare
DavisVaughan
force-pushed
the
feature/sources-6-goto-definition-tests
branch
from
July 2, 2026 18:42
4c919a6 to
571ad70
Compare
DavisVaughan
force-pushed
the
feature/sources-5-delete-oak-sources
branch
from
July 2, 2026 18:53
8c5acb7 to
fdd6456
Compare
DavisVaughan
force-pushed
the
feature/sources-6-goto-definition-tests
branch
2 times, most recently
from
July 2, 2026 18:59
ad23976 to
47ba23c
Compare
DavisVaughan
force-pushed
the
feature/sources-5-delete-oak-sources
branch
2 times, most recently
from
July 2, 2026 19:04
ddd0e90 to
601cf98
Compare
DavisVaughan
force-pushed
the
feature/sources-6-goto-definition-tests
branch
2 times, most recently
from
July 2, 2026 19:11
64f6196 to
10867ff
Compare
DavisVaughan
force-pushed
the
feature/sources-5-delete-oak-sources
branch
from
July 2, 2026 19:11
601cf98 to
42e42f0
Compare
…mportFrom()` With some extracted support infrastructure: `DescriptionWriter`, `NamespaceWriter`, and the generic `TestSourceHandler`
DavisVaughan
force-pushed
the
feature/sources-6-goto-definition-tests
branch
from
July 2, 2026 19:12
10867ff to
82f4d0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1302
With some extracted support infrastructure:
DescriptionWriter,NamespaceWriter, and the genericTestSourceHandlerEven without any additional changes, just hooking up the production
SourceHandlerhas enabled some features we didn't have existing "live" tests for.One of those is goto def on usage of
foo()in your workspace package, whenfoo()comes from a NAMESPACEimport()orimportFrom()