Skip to content

Fix ChatGitHub() to actually use it's base_url #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2025
Merged

Fix ChatGitHub() to actually use it's base_url #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c8c620
Fix ChatGitHub() to actually use it's base_url
cpsievert Sep 18, 2025
3a1ef26
Fix pytest error
cpsievert Sep 18, 2025
030c462
Update changelog
cpsievert Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
-->

## [UNRELEASED]

### Bug fixes

* `ChatGithub()` once again uses the appropriate `base_url` when generating reponses (problem introduced in v0.11.0). (#182)

## [0.13.0] - 2025-09-10

### New features
Expand Down
4 changes: 2 additions & 2 deletions chatlas/_provider_github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def ChatGithub(

class GitHubProvider(OpenAIProvider):
def __init__(self, base_url: str, **kwargs):
super().__init__(**kwargs)
super().__init__(base_url=base_url, **kwargs)
self._base_url = base_url

def list_models(self) -> list[ModelInfo]:
Expand Down Expand Up @@ -190,7 +190,7 @@ def list_models_gh_azure(base_url: str = "https://models.inference.ai.azure.com"
for m in models:
info: ModelInfo = {
"id": m["name"],
"provider": m["publisher"]
"provider": m["publisher"],
}
res.append(info)

Expand Down
2 changes: 1 addition & 1 deletion pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[pytest]
asyncio_mode=strict
asyncio_default_fixture_loop_scope=fixture
asyncio_default_fixture_loop_scope=function