Handle pdf encoding properly when translating to/from Inspect #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of PDF encoding when converting between Chatlas and Inspect content formats. Previously, PDF binary data was incorrectly being decoded/encoded as UTF-8, which would fail for binary content. The fix uses base64 encoding to properly handle PDF data as text-safe strings during serialization.
Key changes:
- Added base64 import for proper binary data encoding
- Updated PDF-to-Inspect conversion to use base64 encoding instead of UTF-8 decoding
- Updated Inspect-to-PDF conversion to use base64 decoding instead of UTF-8 encoding
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205