feat: add reasoning parameter to ChatBedrockAnthropic()#286
Merged
Conversation
ChatAnthropic() already had a reasoning parameter for extended thinking, but ChatBedrockAnthropic() was missing it despite using the same underlying Anthropic SDK client and inheriting from AnthropicProvider.
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: cpsievert <1365941+cpsievert@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoningparameter toChatBedrockAnthropic()for parity withChatAnthropic()int | ThinkingConfigEnabledParam), same coercion logic, same docstringcachedocstring which incorrectly described the default as"5m"when it's actually"none"Motivated by tidyverse/ellmer#965 which added reasoning support to ellmer's Bedrock provider. chatlas already handled the wire format (since
AnthropicBedrockProviderinherits fromAnthropicProvider), but the convenience parameter was missing.Test plan
test_reasoningtotest_provider_bedrock.pywith a recorded VCR cassettepyrightpasses with 0 errors