Constant mapping#48
Merged
thomasp85 merged 10 commits intoposit-dev:mainfrom Jan 12, 2026
Merged
Conversation
- Add Literal variant to GlobalMappingItem - Add HashSet import for compute_aesthetic_labels - Fix resolve_global_mappings to handle Literal variants - Add compute_aesthetic_labels method These features were lost during the merge resolution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
georgestagg
approved these changes
Jan 12, 2026
Collaborator
georgestagg
left a comment
georgestagg
left a comment
There was a problem hiding this comment.
LGTM!
Just a minor issue below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #42
This turned out to be a much larger ordeal than anticipated but in the end I prevailed. Constants in MAPPING are now materialised as a column in the data. If the layer is using the global data then the column is materialised there rather than copying over the global data to the layer. This ensures that faceting still works in the face of constant mappings.
I this PR I also fix setting aesthetics to literals inside SETTING. Examples of this are littered over the code base but it has never worked - it does now.
Lastly I have formalised how labels are derived from mappings (Manual labels > column name > aesthetic name)