Skip to content

Colour semantics#54

Merged
teunbrand merged 16 commits intoposit-dev:mainfrom
teunbrand:color_fill_stroke
Jan 22, 2026
Merged

Colour semantics#54
teunbrand merged 16 commits intoposit-dev:mainfrom
teunbrand:color_fill_stroke

Conversation

@teunbrand
Copy link
Copy Markdown
Collaborator

@teunbrand teunbrand commented Jan 13, 2026

This PR aims to fix #23.

It does the following things:

  • Adds stroke as a supported aesthetic.
  • Standardises the UK spelling of 'colour' to US spelling of 'color'. Users can use either one, it will get translated internally.
  • Default stroke and fill to color.

@teunbrand teunbrand changed the title Color fill stroke Colour semantics Jan 13, 2026
teunbrand
teunbrand commented Jan 13, 2026
View reviewed changes
Comment thread src/parser/ast.rs Outdated
teunbrand
teunbrand commented Jan 13, 2026
View reviewed changes
Comment thread src/parser/ast.rs Outdated
@teunbrand
Copy link
Copy Markdown
Collaborator Author

teunbrand commented Jan 14, 2026

I want to use some juicy bits of #52 to deal with #48 implications for this PR.

@teunbrand
Copy link
Copy Markdown
Collaborator Author

teunbrand commented Jan 20, 2026 •
edited
Loading

Probably doesn't make sense to advance this PR now when there is a big refactor a-comin'

@thomasp85
Copy link
Copy Markdown
Collaborator

thomasp85 commented Jan 20, 2026

Yes, that is probably wise - hopefully within the next 24h

@teunbrand teunbrand marked this pull request as ready for review January 22, 2026 12:07
@teunbrand teunbrand requested a review from thomasp85 January 22, 2026 12:08
thomasp85
thomasp85 approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 385f4db into posit-dev:main Jan 22, 2026
3 checks passed
@teunbrand teunbrand deleted the color_fill_stroke branch January 22, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change colour aesthetic semantics

2 participants

@teunbrand @thomasp85