Skip to content

Conversation

@bcwu
Copy link
Contributor

@bcwu bcwu commented May 11, 2023

Intent

fixes #422
fix appstore version variable scope issue from #418

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Directions for Reviewers

Deploying from saved servers should now work.

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4193 2650 63% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/api.py 65% 🟢
TOTAL 65% 🟢

updated for commit: c6f8b63 by action🐍

@bcwu bcwu requested a review from mslynch May 11, 2023 14:24
@kgartland-rstudio
Copy link
Contributor

Verified fix.

✅ deployed all content types with -s/-k and with -n.
✅ deployed content with manifest.

Once merged I will re-run the rsconnect-python tests in Connect.

@bcwu bcwu merged commit e7d24cd into master May 11, 2023
@bcwu bcwu deleted the fix-appstore-version-scope branch May 11, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beta Build: No content can be deployed when using a named server

4 participants