Add rsconnect server set-default and a server command group#818
Merged
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
karawoo
approved these changes
Jul 13, 2026
karawoo
left a comment
Contributor
There was a problem hiding this comment.
nice, I like the addition of the server group
Comment on lines
+999
to
+1000
| These subcommands are aliases for the top-level add, list, remove, and | ||
| details commands, grouped under a single namespace. |
Contributor
There was a problem hiding this comment.
I feel like this implies that set-default also exists as a top-level command. There's nothing in the docstring that suggests set-default is different from the rest of the server commands.
817b528 to
b169f69
Compare
edavidaja
commented
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
rsconnect server set-default -n <name> | -s <url>to mark an already-saved server as the default without re-adding it, and introduces arsconnect servercommand group as the home for server management.The
servercommand groupA single Click
Commandobject can belong to multiple groups, so the group reuses the existingadd/list/remove/details/bootstrapcommand objects — no duplication; the top-level commands are unchanged and keep working.set-defaultis new and registered only under the group.rsconnect server add|list|remove|details|bootstrap— aliases of the existing top-level commandsrsconnect server set-default— new; the only entry point for this commandlogin/logoutare intentionally not in the group — they stay top-level (common publisher commands).bootstrap(rare server-provisioning) is grouped.Behavior notes
set-defaultis local only — no server contact/re-validation; usersconnect details -n <name>to re-check.-smatches the stored, normalized URL exactly (likeremove -s); prefer-n. Reports the resolved nickname.-n/-srequired.Tests & docs
Coverage in
tests/test_main.pyfor set-default (name/URL, errors, both/neither, idempotency, shinyapps.io, no top-levelset-default), group help, and the alias wiring. Newdocs/commands/set-default.md+ CHANGELOG entry. Suite green, lint clean.